Guide for Hama Committers

This page contains guidelines for committers.

Review

Hama committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they've not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.

For non-trivial changes, it is best to get another committer to review your own patches before commit. Use "Submit Patch" like other contributors, and then wait for a "+1" from another committer before committing.

Reject

Patches should be rejected which do not adhere to the guidelines in HowToContribute and to the CodeReviewChecklist. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

Commit

When you commit a patch, please:

Configuring the Subversion client
Add an entry in CHANGES.txt, at the end of the appropriate section. This should include the Jira issue id, and the name of the contributor.
Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you. Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these).
Resolve the issue as fixed, thanking the contributor. Always set the "Fix Version" at this point, but please only set a single fix version, the earliest release in which the change will appear.

Keys

You may want to add your KEY to http://incubator.apache.org/hama/KEYS

To add your KEY, you can add text to src/site/resources/files/KEYS file. and recommend to use a 4096 bit RSA key.

See http://www.apache.org/dev/release-signing.html and http://www.apache.org/dev/openpgp.html

Then, you can create release candidate with following command:

mvn clean install package gpg:sign

Verify Release

To verify a release, which is normally done by the committers, you can do the following:

1. Download the RC's package asc, the url must be given by the release manager starting the vote thread.

wget <SOME URL>/hama-0.x.0-incubating.tar.gz.asc

2. Import the committers keys

wget http://incubator.apache.org/hama/KEYS
gpg --import http://incubator.apache.org/hama/KEYS

Note that the last argument after import is a file, not a url.

3. Verify

gpg --verify hama-0.x.0-incubating.tar.gz.asc