Differences between revisions 4 and 5
Revision 4 as of 2006-12-07 16:39:03
Size: 1288
Comment:
Revision 5 as of 2009-09-20 21:54:34
Size: 1290
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 1: Line 1:
Line numbers relate to [attachment:finalize.cpp.ps finalize.cpp]. Line numbers relate to [[attachment:finalize.cpp.ps|finalize.cpp]].

Line numbers relate to finalize.cpp.

  • 1 Zakirov->Afremov

  • 10-32 Two many includes, for all files
  • 35-38 running_finalizers_deferred clean up
  • 42-63 update the comment
  • 65 clean up event handle
  • 69-71 use standard vector
  • 83 investigate if could use vector of handles here to support automatic enumeration
  • 84 rename to start_finalizer_threads
  • 85 rename to run_finalizers
  • 87 use a unified model for references and finalizers
  • 146 check with threading team if we could store the flag more effectively (1 bit?)
  • 156 make a comment that it is for the case when VM is not fully initialized
  • 152, 165 add comment what false means
  • investigate if number of calls to signal VM to run finalizers could be decreased
  • 188 no need to finalizeObject() – could call finalize() directly
  • 179 attribute never changed to false
  • file new bug: investigate if TRACE should work in suspend disabled mode
  • move line 196->199, 202 delete

Design notes:

  • Move queue to java heap
  • Keep the whole list of references to all objects with finalizers in java and introduce attribute for each reference if it requires finalization
  • As a quick solution let’s introduce bufferization (Object array of the fixed size)

Code_Inspection:_finalize.cpp (last edited 2009-09-20 21:54:34 by localhost)