Differences between revisions 8 and 9
Revision 8 as of 2014-06-23 10:24:00
Size: 1016
Editor: JulianFoad
Comment:
Revision 9 as of 2014-06-23 14:30:15
Size: 1317
Editor: brane
Comment:
Deletions are marked like this. Additions are marked like this.
Line 16: Line 16:
 * svn_relpath_limit — Is this really a good public API, either in functionality or in name? I suggest it should be a local function in the one file where it's used, or else made private and named 'svn_relpath__first_n_components'.  * `svn_relpath_limit` — Is this really a good public API, either in functionality or in name? I suggest it should be a local function in the one file where it's used, or else made private and named 'svn_relpath__first_n_components'.
Line 19: Line 19:
 * svn_null_pointer_constant_stdarg_sentinel_t — Should this be private?  * `svn_null_pointer_constant_stdarg_sentinel_t` — Should this be private?
   * No; the idea is that API users can use `SVN_VA_NULL`. Note that the definition is a forward declaration of the type for the purpose of making it a pointer constant that's not trivially assignable to anything else (except `void*`), but the type itself is never defined, on purpose. — brane

Svn19ApiReview

This page contains a list of all the new additions to the public Subversion 1.9-dev API.


Needs Review


Reviewed But Need Further Attention

svn_client.h

New functions:

  • svn_client_vacuum — Missing documentation for arguments fix_recorded_timestamps and vacuum_pristines. (svn praise: r1548088 rhuijben)

  • svn_client_cleanup2 — Missing documentation for arguments fix_recorded_timestamps, clear_dav_cache and vacuum_pristines. (svn praise: r1548088 rhuijben)

  • svn_client_cleanup — Missing SVN_DEPRECATED annotation.

svn_dirent_uri.h

  • svn_relpath_limit — Is this really a good public API, either in functionality or in name? I suggest it should be a local function in the one file where it's used, or else made private and named 'svn_relpathfirst_n_components'.

svn_types.h

  • svn_null_pointer_constant_stdarg_sentinel_t — Should this be private?

    • No; the idea is that API users can use SVN_VA_NULL. Note that the definition is a forward declaration of the type for the purpose of making it a pointer constant that's not trivially assignable to anything else (except void*), but the type itself is never defined, on purpose. — brane


Review Completed!

Nothing yet.

Svn19ApiReview (last edited 2014-06-23 14:30:15 by brane)