This document is a draft

Thrift currently uses a combination of "Commit Then Review" (CTR) and "Review Then Commit".

Commit Then Review

Thrift committers are given a bit of leeway with "trivial" changes. If a committer has a small change that he believes will be non-contentious, he may commit it directly to the Subversion trunk, without getting a prior review. Other committers and contributors are free to yell at him when they get the commit notification email.

Review Then Commit

Larger or trickier changes must first be submitted to the community for review. The process for submitting patches is the same for committers and non-committers. Details at SubmittingPatches.

  • No labels