Differences between revisions 2 and 3
Revision 2 as of 2008-06-11 21:24:27
Size: 1627
Editor: DougCutting
Comment:
Revision 3 as of 2009-09-20 23:47:13
Size: 1629
Editor: localhost
Comment: converted to 1.6 markup
Deletions are marked like this. Additions are marked like this.
Line 19: Line 19:
This method is currently only available to individuals who have an [http://www.apache.org/licenses/#clas ICLA] on file with Apache. This method is currently only available to individuals who have an [[http://www.apache.org/licenses/#clas|ICLA]] on file with Apache.

This document is a draft.

Any nontrivial patch or patch series submitted to Thrift (by a committer or contributor) must be tracked in a JIRA issue. There are two ways to associate a patch with an issue, though the second is currently only available to developers who have signed an ICLA (for legal reasons).

Attaching a patch directly to the issue

This is the standard Apache practice. Just attach your patch in the JIRA ticket. Be sure to check the box that allows your work to be distributed under the ASL. Also, be sure to indicate the following.

  1. What the base of your patch is. If you use svn diff, this should be obvious. If not, please say something like "this is a patch against release X."
  2. What order your patches should be applied in, if there is more than one.
  3. What would be an appropriate commit message for each patch. We could add a 'commit message' field to Thrift Jira issues for this, if you like. --DougCutting

Publishing a patch via Git

This method is currently only available to individuals who have an ICLA on file with Apache.

  • Get access to the GitRepository.

  • Push a branch containing your submission, with as clean a commit history as possible, and good commit messages.
  • Create a JIRA issue to discuss your change. Include the name of your branch. For convenience please include a link to the commitdiff (for one commit) or newlog (for a series) in Gitweb.
  • It might also be good to include the commit hash so that people will know what you originally posted if you later update your branch.

SubmittingPatches (last edited 2009-09-20 23:47:13 by localhost)