This page contains Pig-specific guidelines for committers.
New committers are encouraged to first read Apache's generic
committer documentation:
Pig committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they've not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.
The list of submitted patches is in the Pig Review Queue. This is ordered by time of last modification. Committers should scan the list from top-to-bottom, looking for patches that they feel qualified to review and possibly commit.
For non-trivial changes, it is best to get another committer to review your own patches before commit. Set the 'Patch Available' checkbox like other contributors, and then wait for a "+1" from another committer before committing.
Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.
Patches are rejected by editing the issue and un-setting the 'Patch Available' checkbox and adding a comment that politely details the reason(s) for rejection.
When you commit a patch, please:
In addition to code changes, changes to the site documentation might be necessary. If so, please, follow the steps described in HowToDocument#UpdatingthePigSiteDocumentation.