This page contains HCatalog-specific guidelines for committers.
New committers are encouraged to first read Apache's generic committer documentation:
HCatalog committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they have not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.
For non-trivial changes, you must get another committer to review your own patches before committing them.
Issues in the Patch Available state are ready for review.
Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.
Patches are rejected by editing the issue and adding a comment that politely details the reason(s) for rejection.
When you commit a patch:
CHANGES.txt
, at the beginning of the appropriate section (this is so that most recent patches appear first in CHANGES.txt
). This should include the JIRA issue id, the name of the contributor, and the name of the committer (if different from the contributor).HCatalog uses svnpubsub for managing the website (setup in INFRA-5862). To update the website, follow these steps:
svn co https://svn.apache.org/repos/asf/incubator/hcatalog/site/
author/src/documentation/content/xdocs
. See http://forrest.apache.org/ for documentation.ant -Dforrest.home=<forresthome>
where forresthome is the directory you installed forrest in.svn add ... svn commit -m "blah blah" |