Code Review Checklist

Here is a list of things to check during code reviews. Once the review is complete (which means all suggestions from previous reviews have been satisfactorily incorporated and you believe the patch is ready to commit) then please set the Reviewed flag on the issue's Jira. Please do NOT change this list without first discussing the change on the core-dev@ mailing list.

Coding Style

new code:

changes to existing code:


internal javadoc:

public javadoc:




CodeReviewChecklist (last edited 2014-01-06 06:30:18 by 203)