Guide for Hadoop Committers

This page contains Hadoop-specific guidelines for committers.

New committers

New committers are encouraged to first read Apache's generic committer documentation:

The first act of a new committer is typically to add their name to the [http://lucene.apache.org/hadoop/credits.html credits] page. This requires changing the XML source in src/docs/src/documentation/content/xdocs/credits.xml. Once done, update the Hadoop website as described [#CommitToWebsite here].

Review

Hadoop committers should, as often as possible, attempt to review patches submitted by others. Ideally every submitted patch will get reviewed by a committer within a few days. If a committer reviews a patch they've not authored, and believe it to be of sufficient quality, then they can commit the patch, otherwise the patch should be cancelled with a clear explanation for why it was rejected.

The list of submitted patches is in the [https://issues.apache.org/jira/secure/IssueNavigator.jspa?requestId=12311124&mode=hide Hadoop Review Queue]. This is ordered by time of last modification. Committers should scan the list from top-to-bottom, looking for patches that they feel qualified to review and possibly commit.

For non-trivial changes, it is best to get another committer to review your own patches before commit. Use "Submit Patch" like other contributors, and then wait for a "+1" from another committer before committing.

Reject

Patches should be rejected which do not adhere to the guidelines in HowToContribute and to the CodeReviewChecklist. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

Commit

When you commit a patch, please:

  1. Add an entry in CHANGES.txt, at the end of the appropriate section. This should include the Jira issue id, and the name of the contributor.
  2. Include the Jira issue id in the commit message, along with a short description of the change and the name of the contributor if it is not you. Be sure to get the issue id right, as this causes Jira to link to the change in Subversion (use the issue's "All" tab to see these).
  3. Resolve the issue as fixed, thanking the contributor. Always set the "Fix Version" at this point, but please only set a single fix version, the earliest release in which the change will appear.

Anchor(CommitToWebsite)

Committing to the Hadoop website

When you are committing any forrest-based documentation to [http://lucene.apache.org/hadoop/ http://lucene.apache.org/hadoop/] ask the user to submit only changes made to the *.xml files in src/docs. Apply that patch, then run forrest to generate the html files, manually copy the modified files to docs/ and then commit. Now goto /www/lucene.apache.org/hadoop on people.apache.org and 'svn up'.

cd src/docs
forrest site
cd ../..
cp -pr src/docs/build/site/* docs/
svn commit
ssh people.apache.org
cd /www/lucene.apache.org/hadoop
svn up

Dialog

Committers should hang out in the #hadoop room on irc.freenode.net for real-time discussions. However any substantive discussion (as with any off-list project-related discussion) should be re-iterated in Jira or on the developer list.