Access to add and change pages is restricted. See: https://cwiki.apache.org/confluence/display/OFBIZ/Wiki+access

COMPLETE

Codenarc integration review complete

The codenarc changes addressed by this document were merged with ofbiz-framework via PR https://github.com/apache/ofbiz-framework/pull/618

This document can now be archived.


A PR has been created which contains large number of low-risk changes. (Codenarc integration by gilPts · Pull Request #517 · apache/ofbiz-framework (github.com))

Changes are consider low-risk as they modify OFBiz sources to comply with various Codenarc rules.

Although changes are low-risk, committers should still review the changes before the PR is merged with trunk.

Given the large number of changes, it will be useful to share the review effort among multiple committers. This page is intended to track that review effort since there doesn't appear to be a way to individually track reviewed files in GitHub.

Lifecycle for this page

This page is intended to be a temporary resource to assist OFBiz committers in reviewing PR 517 (Codenarc integration by gilPts · Pull Request #517 · apache/ofbiz-framework (github.com))

The page should be deleted (or archived) once the PR merge is complete or if this page turns out not to be helpful in tracking the review effort.

Review approach

Reviewers are asked to visit the PR and assess changed individual files.

If in the reviewers opinion a file change will not change OFBiz behaviour in any way they should mark the corresponding entry in the table below as PASSED.

If the reviewer identifies an issue with a changed file, then they should add a comment in the PR on GitHub AND mark the corresponding entry in the table below as WORK NEEDED.

If the reviewer is unsure how to classify a changed file they should mark the corresponding entry in the table below as UNSURE.

In each of the above cases, the reviewer should add their name against the entry in the table below.

Once any issue highlighted by a WORK NEEDED or UNSURE mark has been addressed to the satisfaction of a reviewer, that reviewer should change the mark in the table below as PASSED. Note that any reviewer can do this. It does not need to be the same reviewer that originally highlighted the concern, however if the concern was complicated it would be prudent to get the original reviewer's feedback.

If you make comments in the PR as part of a review, remember to submit the review frequently so that others can see and respond to your comments.

Table creation method

The table below was created by using the following command to identify all files changed in the PR:

# Checkout the PR
gh pr checkout 517

# See how many files have changed in the PR. Check against the number listed on GitHub
git diff --naname-only 88a014296c0fe7ec1d010bfb836595003aef14c0 HEAD | wc -l

# Save list of changed files to a temporary file, pr-files.
#  88a014296c0fe7ec1d010bfb836595003aef14c0 is the commit hash from where the PR was branched.
git diff --name-only 88a014296c0fe7ec1d010bfb836595003aef14c0 HEAD > pr-files


The pr-files file was then imported into Excel. The table was then copied and pasted into Confluence.

Reviewed files table


File path

Review result

Copy and paste the following lozenges:

PASSED

UNSURE

WORK_NEEDED

WIP

QUESTION

Reviewer(s)

1applications/accounting/groovyScripts/admin/AcctgAdminServices.groovy

PASSED

2applications/accounting/groovyScripts/admin/FilterOutReceipts.groovy

PASSED

Daniel Watford 
3applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy

PASSED

@Daniel Watford  (according to comment in PR)

4applications/accounting/groovyScripts/agreement/AgreementServices.groovy

PASSED

Daniel Watford 
5applications/accounting/groovyScripts/agreement/GetPartyNameForDate.groovy

PASSED

Daniel Watford 
6applications/accounting/groovyScripts/ap/invoices/CommissionReport.groovy

PASSED

Daniel Watford 
7applications/accounting/groovyScripts/ap/invoices/CommissionRun.groovy

PASSED

Daniel Watford 
8applications/accounting/groovyScripts/ar/BatchPayments.groovy

PASSED

Daniel Watford 
9applications/accounting/groovyScripts/budget/BudgetServices.groovy

PASSED

Daniel Watford 
10applications/accounting/groovyScripts/chartofaccounts/TaxAuthorityGlAccounts.groovy

PASSED

Daniel Watford 
11applications/accounting/groovyScripts/fixedasset/FixedAssetGeoLocation.groovy

PASSED

Daniel Watford 
12applications/accounting/groovyScripts/invoice/CreateApplicationList.groovy

PASSED

Daniel Watford 
13applications/accounting/groovyScripts/invoice/EditInvoice.groovy

PASSED

Daniel Watford 
14applications/accounting/groovyScripts/invoice/GetAccountOrganizationAndClass.groovy

PASSED

Jacques Le Roux 
15applications/accounting/groovyScripts/invoice/InvoiceEvents.groovy

PASSED

16applications/accounting/groovyScripts/invoice/InvoiceReport.groovy

PASSED

Jacques Le Roux 
17applications/accounting/groovyScripts/invoice/InvoiceServices.groovy

PASSED

18applications/accounting/groovyScripts/invoice/ListNotAppliedPayments.groovy

PASSED

Daniel Watford 
19applications/accounting/groovyScripts/invoice/PrintInvoices.groovy

PASSED

Daniel Watford 
20applications/accounting/groovyScripts/order/BillingAccountOrders.groovy

PASSED

Daniel Watford 
21applications/accounting/groovyScripts/payment/BillingAccounts.groovy

PASSED

Daniel Watford 
22applications/accounting/groovyScripts/payment/DepositWithdrawPayments.groovy

PASSED

Daniel Watford 
23applications/accounting/groovyScripts/payment/FindInvoicesByDueDate.groovy

PASSED

24applications/accounting/groovyScripts/payment/ListNotAppliedInvoices.groovy

PASSED

Daniel Watford 
25applications/accounting/groovyScripts/payment/ListNotAppliedPayments.groovy

PASSED

Daniel Watford 
26applications/accounting/groovyScripts/payment/ManualTx.groovy

PASSED

Daniel Watford 
27applications/accounting/groovyScripts/payment/PaymentServices.groovy

PASSED

28applications/accounting/groovyScripts/payment/PrintChecks.groovy

PASSED

Daniel Watford 
29applications/accounting/groovyScripts/period/EditCustomTimePeriod.groovy

PASSED

Daniel Watford 
30applications/accounting/groovyScripts/rate/RateServices.groovy

PASSED

Daniel Watford 
31applications/accounting/groovyScripts/reports/BalanceSheet.groovy

PASSED

32applications/accounting/groovyScripts/reports/CashFlowStatement.groovy

PASSED

Daniel Watford 
33applications/accounting/groovyScripts/reports/ComparativeBalanceSheet.groovy

PASSED

Daniel Watford 
34applications/accounting/groovyScripts/reports/ComparativeCashFlowStatement.groovy

PASSED

Daniel Watford 
35applications/accounting/groovyScripts/reports/ComparativeIncomeStatement.groovy

PASSED

Daniel Watford 
36applications/accounting/groovyScripts/reports/CostCenters.groovy

PASSED

37applications/accounting/groovyScripts/reports/GlAccountTrialBalance.groovy

PASSED

38applications/accounting/groovyScripts/reports/IncomeStatement.groovy

PASSED

39applications/accounting/groovyScripts/reports/InvoiceAcctgTransEntryParameters.groovy

PASSED

40applications/accounting/groovyScripts/reports/MonthSelection.groovy

PASSED

41applications/accounting/groovyScripts/reports/SalesInvoiceByProductCategorySummary.groovy

PASSED

42applications/accounting/groovyScripts/reports/TransactionTotals.groovy

PASSED

43applications/accounting/groovyScripts/reports/TrialBalance.groovy

PASSED

44applications/accounting/groovyScripts/transaction/AuthorizeTransaction.groovy

PASSED

45applications/accounting/groovyScripts/transaction/CaptureTransaction.groovy

PASSED

46applications/accounting/groovyScripts/transaction/ViewGatewayResponse.groovy

PASSED

47applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgAdminTests.groovy

PASSED

Daniel Watford 
48applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgAgreementTests.groovy

PASSED

Daniel Watford 
49applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgBudgetTests.groovy

PASSED

Daniel Watford 
50applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgCostTests.groovy

PASSED

Daniel Watford 
51applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgFinAccountTests.groovy

PASSED

52applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgFixedAssetTests.groovy

PASSED

Daniel Watford 
53applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgInvoiceTests.groovy

PASSED

Daniel Watford 
54applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgLedgerTests.groovy

PASSED

Daniel Watford 
55applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgPaymentGatewayTests.groovy

PASSED

Daniel Watford 
56applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgPaymentTests.groovy

PASSED

Daniel Watford 
57applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgTransTestsPurchase.groovy

PASSED

Daniel Watford 
58applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoAcctgTransTestsSales.groovy

PASSED

Daniel Watford 
59applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoInvoiceTests.groovy

PASSED

Daniel Watford 
60applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/AutoPaymentTests.groovy

PASSED

61applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/FixedAssetTests.groovy

PASSED

62applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy

PASSED

63applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/PaymentApplicationTests.groovy

PASSED

64applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/RateTests.groovy

PASSED

65applications/commonext/groovyScripts/ofbizsetup/ChangeOrgPartyId.groovy

PASSED

66applications/commonext/groovyScripts/ofbizsetup/FindFacility.groovy

PASSED

67applications/commonext/groovyScripts/ofbizsetup/GetProdCatalog.groovy

PASSED

68applications/commonext/groovyScripts/ofbizsetup/GetProductStoreAndWebSite.groovy

PASSED

69applications/commonext/groovyScripts/ofbizsetup/SystemInfoServices.groovy

PASSED

70applications/commonext/groovyScripts/template/DocTypeTemplate.groovy

PASSED

71applications/content/groovyScripts/cms/CmsEditAddPrep.groovy

PASSED

72applications/content/groovyScripts/cms/FeaturePrep.groovy

PASSED

73applications/content/groovyScripts/cms/GetMenuContext.groovy

PASSED

74applications/content/groovyScripts/cms/MostRecentPrep.groovy

PASSED

75applications/content/groovyScripts/cms/UserPermPrep.groovy

PASSED

76applications/content/groovyScripts/content/ContentSearchOptions.groovy

PASSED

77applications/content/groovyScripts/content/ContentSearchResults.groovy

PASSED

78applications/content/groovyScripts/content/ContentServices.groovy

PASSED

79applications/content/groovyScripts/content/GetContentLookupList.groovy

PASSED

80applications/content/groovyScripts/content/PrepSeqNo.groovy

PASSED

81applications/content/groovyScripts/contentsetup/UserPermPrep.groovy

PASSED

82applications/content/groovyScripts/data/DataServices.groovy

PASSED

83applications/content/groovyScripts/datasetup/DataCategoryPrep.groovy

PASSED

84applications/content/groovyScripts/layout/EditSubContent.groovy

PASSED

85applications/content/groovyScripts/permission/ContentPermissionServices.groovy

PASSED

86applications/content/groovyScripts/print/FindPrinters.groovy

PASSED

87applications/content/groovyScripts/survey/EditSurveyQuestions.groovy

PASSED

88applications/content/groovyScripts/survey/EditSurveyResponse.groovy

PASSED

89applications/content/groovyScripts/survey/ViewSurveyResponses.groovy

PASSED

90applications/content/groovyScripts/website/EditWebSiteParties.groovy

PASSED

91applications/content/groovyScripts/website/WebSiteCMSMetaInfo.groovy

PASSED

92applications/content/groovyScripts/website/WebSitePublishPoint.groovy

PASSED

93applications/content/src/main/groovy/org/apache/ofbiz/content/BlogServices.groovy

PASSED

94applications/content/src/main/groovy/org/apache/ofbiz/content/ContentTests.groovy

PASSED

95applications/humanres/groovyScripts/category/CategoryTree.groovy

PASSED

96applications/manufacturing/groovyScripts/reports/PRunsInfoAndOrder.groovy

PASSED

97applications/manufacturing/groovyScripts/bom/BomSimulation.groovy

PASSED

98applications/manufacturing/groovyScripts/bom/EditProductBom.groovy

PASSED

99applications/manufacturing/groovyScripts/bom/FindProductBom.groovy

PASSED

100applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunActualComponents.groovy

PASSED

101applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunAllFixedAssets.groovy

PASSED

102applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunComponents.groovy

PASSED

103applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunContent.groovy

PASSED

104applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunCosts.groovy

PASSED

105applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunDeclaration.groovy

PASSED

106applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunFixedAssets.groovy

PASSED

107applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunServices.groovy

PASSED

108applications/manufacturing/groovyScripts/jobshopmgt/ProductionRunTaskParties.groovy

PASSED

109applications/manufacturing/groovyScripts/jobshopmgt/ShowProductionRun.groovy

PASSED

110applications/manufacturing/groovyScripts/jobshopmgt/ViewProductionRun.groovy

PASSED

111applications/manufacturing/groovyScripts/jobshopmgt/WorkWithShipmentPlans.groovy

PASSED

112applications/manufacturing/groovyScripts/mrp/FindInventoryEventPlan.groovy

PASSED

113applications/manufacturing/groovyScripts/reports/CuttingListReport.groovy

PASSED

114applications/manufacturing/groovyScripts/reports/PRunsComponentsByFeature.groovy

PASSED

115applications/manufacturing/groovyScripts/reports/PRunsInfoAndOrder.groovy

PASSED

116applications/manufacturing/groovyScripts/reports/PRunsProductsAndOrder.groovy

PASSED

117applications/manufacturing/groovyScripts/reports/PRunsProductsByFeature.groovy

PASSED

118applications/manufacturing/groovyScripts/reports/PRunsProductsStacks.groovy

PASSED

119applications/manufacturing/groovyScripts/reports/PackageContentsAndOrder.groovy

PASSED

120applications/manufacturing/groovyScripts/reports/ShipmentLabel.groovy

PASSED

121applications/manufacturing/groovyScripts/reports/ShipmentPlanStockReport.groovy

PASSED

122applications/manufacturing/groovyScripts/reports/ShipmentWorkEffortTasks.groovy

PASSED

123applications/manufacturing/groovyScripts/routing/EditCalendar.groovy

PASSED

124applications/manufacturing/groovyScripts/routing/EditCalendarExceptionDay.groovy

PASSED

125applications/manufacturing/groovyScripts/routing/EditCalendarExceptionWeek.groovy

PASSED

126applications/manufacturing/groovyScripts/routing/RoutingServices.groovy

PASSED

127applications/marketing/groovyScripts/marketing/contact/GetContactListMarketingEmail.groovy

PASSED

128applications/marketing/groovyScripts/marketing/reports/EmailStatusReport.groovy

PASSED

129applications/marketing/groovyScripts/marketing/reports/MarketingCampaignReport.groovy

PASSED

130applications/marketing/groovyScripts/marketing/reports/PartyStatusReport.groovy

PASSED

131applications/marketing/groovyScripts/marketing/reports/TrackingCodeReport.groovy

PASSED

132applications/marketing/groovyScripts/sfa/CloneLead.groovy

PASSED

133applications/marketing/groovyScripts/sfa/MergeContacts.groovy

PASSED

134applications/marketing/groovyScripts/sfa/account/AccountServices.groovy

PASSED

135applications/marketing/groovyScripts/sfa/lead/LeadServices.groovy

PASSED

136applications/marketing/src/main/groovy/org/apache/ofbiz/marketing/MarketingTests.groovy

PASSED

137applications/order/groovyScripts/allocationplan/CreateAllocationPlan.groovy

PASSED

138applications/order/groovyScripts/allocationplan/ListAllocationPlan.groovy

PASSED

139applications/order/groovyScripts/allocationplan/ViewAllocationPlan.groovy

PASSED

140applications/order/groovyScripts/communications/CommunicationServices.groovy

PASSED

141applications/order/groovyScripts/entry/AddGiftCertificates.groovy

PASSED

142applications/order/groovyScripts/entry/AdditionalPartyListing.groovy

PASSED

Mekika Leila  (according to comment in PR)

143applications/order/groovyScripts/entry/BillSettings.groovy

PASSED

Mekika Leila  (according to comment in PR)

144applications/order/groovyScripts/entry/CheckInits.groovy

PASSED

145applications/order/groovyScripts/entry/CheckoutOptions.groovy

PASSED

146applications/order/groovyScripts/entry/CheckoutPayment.groovy

PASSED

147applications/order/groovyScripts/entry/CheckoutReview.groovy

PASSED

148applications/order/groovyScripts/entry/CheckoutShippingAddress.groovy

PASSED

149applications/order/groovyScripts/entry/OptionSettings.groovy

PASSED

150applications/order/groovyScripts/entry/OrderAgreements.groovy

PASSED

151applications/order/groovyScripts/entry/OrderTerms.groovy

PASSED

152applications/order/groovyScripts/entry/SetAdditionalParty.groovy

PASSED

153applications/order/groovyScripts/entry/SetCheckOutTabBar.groovy

PASSED

154applications/order/groovyScripts/entry/ShipSettings.groovy

PASSED

155applications/order/groovyScripts/entry/ShoppingList.groovy

PASSED

156applications/order/groovyScripts/entry/ShowCart.groovy

PASSED

157applications/order/groovyScripts/entry/ShowPromoText.groovy

PASSED

158applications/order/groovyScripts/entry/SplitShip.groovy

PASSED

159applications/order/groovyScripts/entry/StorePaymentOptions.groovy

PASSED

160applications/order/groovyScripts/entry/cart/LookupBulkAddProducts.groovy

PASSED

161applications/order/groovyScripts/entry/cart/LookupBulkAddSupplierProducts.groovy

PASSED

162applications/order/groovyScripts/entry/cart/ShowPromotionDetails.groovy

PASSED

163applications/order/groovyScripts/entry/catalog/AdvancedSearchOptions.groovy

PASSED

164applications/order/groovyScripts/entry/catalog/Category.groovy

PASSED

165applications/order/groovyScripts/entry/catalog/CategoryDetail.groovy

PASSED

166applications/order/groovyScripts/entry/catalog/ChooseCatalog.groovy

PASSED

167applications/order/groovyScripts/entry/catalog/CompareProducts.groovy

PASSED

168applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy

PASSED

Gil Portenseigne 
169applications/order/groovyScripts/entry/catalog/KeywordSearch.groovy

PASSED

170applications/order/groovyScripts/entry/catalog/KeywordSearchOptions.groovy

PASSED

171applications/order/groovyScripts/entry/catalog/PrepareConfigForm.groovy

PASSED

172applications/order/groovyScripts/entry/catalog/Product.groovy

PASSED

173applications/order/groovyScripts/entry/catalog/ProductDetail.groovy

PASSED

174applications/order/groovyScripts/entry/catalog/ProductSummary.groovy

PASSED

175applications/order/groovyScripts/entry/catalog/ProductUomDropDownOnly.groovy

PASSED

176applications/order/groovyScripts/entry/catalog/QuickAdd.groovy

PASSED

177applications/order/groovyScripts/entry/catalog/SideDeepCategory.groovy

PASSED

178applications/order/groovyScripts/lookup/LookupAssociatedProducts.groovy

PASSED

179applications/order/groovyScripts/order/AddOrderAttachments.groovy

PASSED

180applications/order/groovyScripts/order/CheckoutServices.groovy

PASSED

181applications/order/groovyScripts/order/CompanyHeader.groovy

PASSED

182applications/order/groovyScripts/order/FilterOrderList.groovy

PASSED

183applications/order/groovyScripts/order/FindOrders.groovy

PASSED

184applications/order/groovyScripts/order/NewNote.groovy

PASSED

185applications/order/groovyScripts/order/OrderDeliveryScheduleInfo.groovy

PASSED

186applications/order/groovyScripts/order/OrderDeliveryServices.groovy

PASSED

187applications/order/groovyScripts/order/OrderHistory.groovy

PASSED

188applications/order/groovyScripts/order/OrderList.groovy

PASSED

189applications/order/groovyScripts/order/OrderRequirementServices.groovy

PASSED

190applications/order/groovyScripts/order/OrderReturnServices.groovy

PASSED

191applications/order/groovyScripts/order/OrderServices.groovy

PASSED

192applications/order/groovyScripts/order/OrderStats.groovy

PASSED

193applications/order/groovyScripts/order/OrderView.groovy

PASSED

194applications/order/groovyScripts/order/OrderViewWebSecure.groovy

PASSED

195applications/order/groovyScripts/order/ReceivePayment.groovy

PASSED

196applications/order/groovyScripts/order/SendConfirmationEmail.groovy

PASSED

197applications/order/groovyScripts/order/ShipGroups.groovy

PASSED

198applications/order/groovyScripts/order/ViewImage.groovy

PASSED

199applications/order/groovyScripts/quote/GetPartyAddress.groovy

PASSED

200applications/order/groovyScripts/quote/GetPartyEmailAddress.groovy

PASSED

201applications/order/groovyScripts/quote/ManageQuotePrices.groovy

PASSED

202applications/order/groovyScripts/quote/QuoteServices.groovy

PASSED

203applications/order/groovyScripts/quote/ViewQuoteProfit.groovy

PASSED

204applications/order/groovyScripts/reports/OpenOrderItemsReport.groovy

PASSED

205applications/order/groovyScripts/request/GetNextSequenceNum.groovy

PASSED

206applications/order/groovyScripts/request/RequestItemNotes.groovy

PASSED

207applications/order/groovyScripts/request/SetRequestQuote.groovy

PASSED

208applications/order/groovyScripts/requirement/ApprovedProductRequirements.groovy

PASSED

209applications/order/groovyScripts/requirement/ApprovedProductRequirementsByVendor.groovy

PASSED

210applications/order/groovyScripts/requirement/SelectCreatedProposed.groovy

PASSED

211applications/order/groovyScripts/return/QuickReturn.groovy

PASSED

212applications/order/groovyScripts/return/ReturnHeader.groovy

PASSED

213applications/order/groovyScripts/return/ReturnHistory.groovy

PASSED

214applications/order/groovyScripts/return/ReturnItems.groovy

PASSED

215applications/order/groovyScripts/setup/PaymentSetup.groovy

PASSED

216applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy

PASSED

217applications/order/groovyScripts/task/OrderTaskList.groovy

PASSED

218applications/order/src/main/groovy/org/apache/ofbiz/order/OrderRequirementTests.groovy

PASSED

Jacques Le Roux 
219applications/order/src/main/groovy/org/apache/ofbiz/order/OrderReturnTests.groovy

PASSED

Jacques Le Roux 
220applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

PASSED

Jacques Le Roux 
221applications/order/src/main/groovy/org/apache/ofbiz/order/QuoteTests.groovy

PASSED

Jacques Le Roux 
222applications/order/src/main/groovy/org/apache/ofbiz/order/ShoppingListTests.groovy

PASSED

Jacques Le Roux 
223applications/order/src/main/groovy/org/apache/ofbiz/order/TestCustRequestPermissionCheck.groovy

PASSED

224applications/party/groovyScripts/HasPartyPermissions.groovy

PASSED

225applications/party/groovyScripts/communication/CommunicationEventServices.groovy

PASSED

226applications/party/groovyScripts/communication/FindCommEventContactMechs.groovy

PASSED

227applications/party/groovyScripts/communication/GetMyCommunicationEventRole.groovy

PASSED

228applications/party/groovyScripts/communication/GetPartyEmailAttachment.groovy

PASSED

229applications/party/groovyScripts/communication/GetPartyEmailFromCommEventInfo.groovy

PASSED

230applications/party/groovyScripts/communication/ListCommunications.groovy

PASSED

231applications/party/groovyScripts/communication/RecentVisitor.groovy

PASSED

232applications/party/groovyScripts/contact/ContactMechServices.groovy

PASSED

233applications/party/groovyScripts/party/EditContactMech.groovy

PASSED

234applications/party/groovyScripts/party/EditPaymentMethod.groovy

PASSED

235applications/party/groovyScripts/party/EditShoppingList.groovy

PASSED

Jacques Le Roux 
236applications/party/groovyScripts/party/FindLookUp.groovy

PASSED

Jacques Le Roux 
237applications/party/groovyScripts/party/FindMatches.groovy

PASSED

Jacques Le Roux 
238applications/party/groovyScripts/party/FindParty.groovy

PASSED

Jacques Le Roux 
239applications/party/groovyScripts/party/GetContactMechs.groovy

PASSED

Jacques Le Roux 
240applications/party/groovyScripts/party/GetCurrentCart.groovy

PASSED

Jacques Le Roux 
241applications/party/groovyScripts/party/GetGeoLocation.groovy

PASSED

Jacques Le Roux 
242applications/party/groovyScripts/party/GetLoyaltyPoints.groovy

PASSED

Daniel Watford 
243applications/party/groovyScripts/party/GetMyCompany.groovy

PASSED

Daniel Watford 
244applications/party/groovyScripts/party/GetPaymentMethods.groovy

PASSED

Daniel Watford 
245applications/party/groovyScripts/party/GetPostalAddressTemplate.groovy

PASSED

Daniel Watford 
246applications/party/groovyScripts/party/GetUserLoginPrimaryEmail.groovy

PASSED

Daniel Watford 
247applications/party/groovyScripts/party/LookupServices.groovy

PASSED

Daniel Watford 
248applications/party/groovyScripts/party/PartyFinancialHistory.groovy

PASSED

Daniel Watford 
249applications/party/groovyScripts/party/PartyGeoLocation.groovy

PASSED

250applications/party/groovyScripts/party/PartyInvitationServices.groovy

PASSED

251applications/party/groovyScripts/party/PartyPermissionServices.groovy

PASSED

252applications/party/groovyScripts/party/PartyServices.groovy

PASSED

253applications/party/groovyScripts/party/PartySimpleMethods.groovy

PASSED

254applications/party/groovyScripts/party/SetRoleVars.groovy

PASSED

255applications/party/groovyScripts/party/StatusCondition.groovy

PASSED

256applications/party/groovyScripts/party/UnAppliedInvoicesForParty.groovy

PASSED

257applications/party/groovyScripts/party/UnAppliedPaymentsForParty.groovy

PASSED

258applications/party/groovyScripts/party/ViewProfile.groovy

PASSED

259applications/party/groovyScripts/visit/ShowVisits.groovy

PASSED

260applications/party/groovyScripts/visit/VisitDetails.groovy

PASSED

261applications/party/src/main/groovy/org/apache/ofbiz/party/ContactMechWorkerTests.groovy

PASSED

Jacques Le Roux 
262applications/party/src/main/groovy/org/apache/ofbiz/party/PartyContactMechTests.groovy

PASSED

Jacques Le Roux 
263applications/party/src/main/groovy/org/apache/ofbiz/party/PartyStatusChangeTests.groovy

PASSED

264applications/party/src/main/groovy/org/apache/ofbiz/party/PartyTests.groovy

PASSED

Jacques Le Roux 
265applications/product/groovyScripts/catalog/ChooseTopCategory.groovy

PASSED

Jacques Le Roux 
266applications/product/groovyScripts/catalog/FastLoadCache.groovy

PASSED

Jacques Le Roux 
267applications/product/groovyScripts/catalog/GetSupplierInventories.groovy

PASSED

Jacques Le Roux 
268applications/product/groovyScripts/catalog/PrepareCreateShipMeth.groovy

PASSED

Jacques Le Roux 
269applications/product/groovyScripts/catalog/PrepareCreateShipmentTimeEstimate.groovy

PASSED

Jacques Le Roux 
270applications/product/groovyScripts/catalog/category/CategoryTree.groovy

PASSED

Jacques Le Roux 
271applications/product/groovyScripts/catalog/category/CreateProductInCategoryCheckExisting.groovy

PASSED

Jacques Le Roux 
272applications/product/groovyScripts/catalog/category/EditCategory.groovy

PASSED

Jacques Le Roux 
273applications/product/groovyScripts/catalog/category/EditCategoryContentContent.groovy

PASSED

Jacques Le Roux 
274applications/product/groovyScripts/catalog/category/EditCategoryProducts.groovy

PASSED

Jacques Le Roux 
275applications/product/groovyScripts/catalog/category/EditCategorySEO.groovy

PASSED

Jacques Le Roux 
276applications/product/groovyScripts/catalog/config/EditProductConfigItemContent.groovy

PASSED

Jacques Le Roux 
277applications/product/groovyScripts/catalog/config/EditProductConfigItemContentContent.groovy

PASSED

Jacques Le Roux 
278applications/product/groovyScripts/catalog/feature/EditFeatureCategoryFeatures.groovy

PASSED

Jacques Le Roux 
279applications/product/groovyScripts/catalog/feature/EditFeatureGroups.groovy

PASSED

Jacques Le Roux 
280applications/product/groovyScripts/catalog/feature/QuickAddProductFeatures.groovy

PASSED

Jacques Le Roux 
281applications/product/groovyScripts/catalog/find/AdvancedSearchOptions.groovy

PASSED

Jacques Le Roux 
282applications/product/groovyScripts/catalog/find/KeywordSearch.groovy

PASSED

Jacques Le Roux 
283applications/product/groovyScripts/catalog/find/KeywordSearchBox.groovy

PASSED

Jacques Le Roux 
284applications/product/groovyScripts/catalog/find/MiniProductList.groovy

PASSED

Jacques Le Roux 
285applications/product/groovyScripts/catalog/find/SideCatalogs.groovy

PASSED

Jacques Le Roux 
286applications/product/groovyScripts/catalog/find/SideDeepCategory.groovy

PASSED

Jacques Le Roux 
287applications/product/groovyScripts/catalog/imagemanagement/CheckAction.groovy

PASSED

Jacques Le Roux 
288applications/product/groovyScripts/catalog/imagemanagement/CheckRejected.groovy

PASSED

Jacques Le Roux 
289applications/product/groovyScripts/catalog/imagemanagement/ImageFrame.groovy

PASSED

Jacques Le Roux 
290applications/product/groovyScripts/catalog/imagemanagement/ImageGallery.groovy

PASSED

Jacques Le Roux 
291applications/product/groovyScripts/catalog/imagemanagement/ImageRecentlyApproved.groovy

PASSED

Jacques Le Roux 
292applications/product/groovyScripts/catalog/imagemanagement/ImageUpload.groovy

PASSED

Jacques Le Roux 
293applications/product/groovyScripts/catalog/imagemanagement/SeoLocales.groovy

PASSED

294applications/product/groovyScripts/catalog/imagemanagement/SetDefaultImage.groovy

PASSED

Jacques Le Roux 
295applications/product/groovyScripts/catalog/imagemanagement/SortSequenceNum.groovy

PASSED

296applications/product/groovyScripts/catalog/lookup/LookupVariantProduct.groovy

PASSED

Jacques Le Roux 
297applications/product/groovyScripts/catalog/price/EditProductPriceRules.groovy

PASSED

Jacques Le Roux 
298applications/product/groovyScripts/catalog/product/ApplyFeaturesFromCategory.groovy

PASSED

Jacques Le Roux 
299applications/product/groovyScripts/catalog/product/ApplyFeaturesFromGroup.groovy

PASSED

Jacques Le Roux 
300applications/product/groovyScripts/catalog/product/BestProducts.groovy

PASSED

Jacques Le Roux 
301applications/product/groovyScripts/catalog/product/EditProductAssoc.groovy

PASSED

Jacques Le Roux 
302applications/product/groovyScripts/catalog/product/EditProductContent.groovy

PASSED

Jacques Le Roux 
303applications/product/groovyScripts/catalog/product/EditProductContentContent.groovy

PASSED

Jacques Le Roux 
304applications/product/groovyScripts/catalog/product/EditProductFeatures.groovy

PASSED

305applications/product/groovyScripts/catalog/product/EditProductInventoryItems.groovy

PASSED

Jacques Le Roux 
306applications/product/groovyScripts/catalog/product/EditProductQuickAdmin.groovy

PASSED

Jacques Le Roux 
307applications/product/groovyScripts/catalog/product/EditProductSEO.groovy

PASSED

308applications/product/groovyScripts/catalog/product/QuickAddVariants.groovy

PASSED

Jacques Le Roux 
309applications/product/groovyScripts/catalog/promo/EditProductPromoCode.groovy

PASSED

Jacques Le Roux 
310applications/product/groovyScripts/catalog/store/EditProductStorePaySetup.groovy

PASSED

Jacques Le Roux 
311applications/product/groovyScripts/catalog/store/EditProductStoreSurveys.groovy

PASSED

Jacques Le Roux 
312applications/product/groovyScripts/catalog/thesaurus/EditKeywordThesaurus.groovy

PASSED

313applications/product/groovyScripts/facility/facility/ComputeProductSellThroughData.groovy

PASSED

Daniel Watford 
314applications/product/groovyScripts/facility/facility/CountFacilityInventoryByProduct.groovy

PASSED

315applications/product/groovyScripts/facility/facility/EditContactMech.groovy

PASSED

316applications/product/groovyScripts/facility/facility/EditFacility.groovy

PASSED

317applications/product/groovyScripts/facility/facility/EditFacilityLocation.groovy

PASSED

Daniel Watford 
318applications/product/groovyScripts/facility/facility/FacilityGeoServices.groovy

PASSED

Jacques Le Roux 
319applications/product/groovyScripts/facility/facility/FacilityLocationGeoLocation.groovy

PASSED

320applications/product/groovyScripts/facility/facility/FindFacility.groovy

PASSED

Daniel Watford 
321applications/product/groovyScripts/facility/facility/FindFacilityLocation.groovy

PASSED

Daniel Watford 
322applications/product/groovyScripts/facility/facility/FindFacilityTransfers.groovy

PASSED

Daniel Watford 
323applications/product/groovyScripts/facility/facility/FindInventoryItemsByLabels.groovy

PASSED

Daniel Watford 
324applications/product/groovyScripts/facility/facility/ViewContactMechs.groovy

PASSED

Daniel Watford 
325applications/product/groovyScripts/facility/facility/ViewFacilityInventoryByProduct.groovy

PASSED

Daniel Watford 
326applications/product/groovyScripts/facility/inventory/FindFacilityPhysicalInventory.groovy

PASSED

327applications/product/groovyScripts/facility/inventory/InventoryAverageCosts.groovy

PASSED

328applications/product/groovyScripts/facility/inventory/InventoryItemTotals.groovy

PASSED

329applications/product/groovyScripts/facility/inventory/LookupInventoryItems.groovy

PASSED

330applications/product/groovyScripts/facility/inventory/PhysicalInventoryVariance.groovy

PASSED

331applications/product/groovyScripts/facility/inventory/ReceiveInventory.groovy

PASSED

332applications/product/groovyScripts/facility/inventory/TransferInventoryItem.groovy

PASSED

333applications/product/groovyScripts/facility/returns/ReceiveReturn.groovy

PASSED

334applications/product/groovyScripts/facility/shipment/AddItemsFromInventory.groovy

PASSED

335applications/product/groovyScripts/facility/shipment/AddItemsFromOrder.groovy

PASSED

336applications/product/groovyScripts/facility/shipment/EditShipment.groovy

PASSED

337applications/product/groovyScripts/facility/shipment/EditShipmentItems.groovy

PASSED

338applications/product/groovyScripts/facility/shipment/EditShipmentPackages.groovy

PASSED

339applications/product/groovyScripts/facility/shipment/EditShipmentPlan.groovy

PASSED

340applications/product/groovyScripts/facility/shipment/EditShipmentRouteSegments.groovy

PASSED

341applications/product/groovyScripts/facility/shipment/PackOrder.groovy

PASSED

342applications/product/groovyScripts/facility/shipment/PackingSlip.groovy

PASSED

343applications/product/groovyScripts/facility/shipment/PrintPickSheets.groovy

PASSED

344applications/product/groovyScripts/facility/shipment/QuickShipOrder.groovy

PASSED

345applications/product/groovyScripts/facility/shipment/ReceiveInventoryAgainstPurchaseOrder.groovy

PASSED

346applications/product/groovyScripts/facility/shipment/ReviewOrdersNotPickedOrPacked.groovy

PASSED

347applications/product/groovyScripts/facility/shipment/ShipmentManifest.groovy

PASSED

348applications/product/groovyScripts/facility/shipment/VerifyPick.groovy

PASSED

349applications/product/groovyScripts/facility/shipment/ViewShipment.groovy

PASSED

350applications/product/groovyScripts/facility/shipment/WeightPackage.groovy

PASSED

351applications/product/groovyScripts/facility/storage/StorageServices.groovy

PASSED

352applications/product/groovyScripts/product/catalog/CatalogServices.groovy

PASSED

353applications/product/groovyScripts/product/category/CategoryContentServices.groovy

PASSED

354applications/product/groovyScripts/product/category/CategoryServices.groovy

PASSED

355applications/product/groovyScripts/product/config/ProductConfigItemContentServices.groovy

PASSED

356applications/product/groovyScripts/product/cost/CostServices.groovy

PASSED

357applications/product/groovyScripts/product/feature/ProductFeatureServices.groovy

PASSED

358applications/product/groovyScripts/product/imagemanagement/ImageManagementServices.groovy

PASSED

359applications/product/groovyScripts/product/inventory/InventoryIssueServices.groovy

PASSED

360applications/product/groovyScripts/product/price/PriceServices.groovy

PASSED

361applications/product/groovyScripts/product/product/ProductContentServices.groovy

PASSED

362applications/product/groovyScripts/product/product/ProductServices.groovy

PASSED

363applications/product/groovyScripts/product/promo/ProductPromoActionServices.groovy

PASSED

364applications/product/groovyScripts/product/promo/ProductPromoCondServices.groovy

PASSED

365applications/product/groovyScripts/product/promo/PromoServices.groovy

PASSED

366applications/product/groovyScripts/product/store/ProductStoreServices.groovy

PASSED

Daniel Watford 
367applications/product/groovyScripts/product/subscription/SubscriptionServices.groovy

PASSED

Daniel Watford 
368applications/product/groovyScripts/product/supplier/SupplierProductServices.groovy

PASSED

Daniel Watford 
369applications/product/groovyScripts/shipment/IssuanceServices.groovy

PASSED

Daniel Watford 
370applications/product/groovyScripts/shipment/PicklistServices.groovy

PASSED

Daniel Watford 
371applications/product/groovyScripts/shipment/ShipmentReceiptServices.groovy

PASSED

Daniel Watford 
372applications/product/groovyScripts/shipment/ShipmentServices.groovy

PASSED

Daniel Watford 
373applications/product/src/main/groovy/org/apache/ofbiz/product/CategoryTests.groovy

PASSED

Daniel Watford 
374applications/product/src/main/groovy/org/apache/ofbiz/product/CostTests.groovy

PASSED

Daniel Watford 
375applications/product/src/main/groovy/org/apache/ofbiz/product/InventoryTests.groovy

PASSED

Daniel Watford 
376applications/product/src/main/groovy/org/apache/ofbiz/product/ProductConfigTests.groovy

PASSED

Daniel Watford 
377applications/product/src/main/groovy/org/apache/ofbiz/product/ProductFeatureTypeTests.groovy

PASSED

Daniel Watford 
378applications/product/src/main/groovy/org/apache/ofbiz/product/ProductPriceTests.groovy

PASSED

Daniel Watford 
379applications/product/src/main/groovy/org/apache/ofbiz/product/ProductPromoActionTests.groovy

PASSED

Daniel Watford 
380applications/product/src/main/groovy/org/apache/ofbiz/product/ProductPromoCondTests.groovy

PASSED

Daniel Watford 
381applications/product/src/main/groovy/org/apache/ofbiz/product/ProductTagTest.groovy

PASSED

Daniel Watford 
382applications/product/src/main/groovy/org/apache/ofbiz/product/ProductTest.groovy

PASSED

Daniel Watford 
383applications/product/src/main/groovy/org/apache/ofbiz/product/ProductTests.groovy

PASSED

Daniel Watford 
384applications/product/src/main/groovy/org/apache/ofbiz/product/ShipmentTests.groovy

PASSED

Daniel Watford 
385applications/product/src/main/groovy/org/apache/ofbiz/shipment/ShipmentCostTests.groovy

PASSED

Daniel Watford 
386applications/workeffort/groovyScripts/ical/IsCalOwner.groovy

PASSED

Daniel Watford 
387applications/workeffort/groovyScripts/workeffort/calendar/CreateUrlParam.groovy

PASSED

Daniel Watford 
388applications/workeffort/groovyScripts/workeffort/calendar/Days.groovy

PASSED

Daniel Watford 
389applications/workeffort/groovyScripts/workeffort/calendar/Month.groovy

PASSED

Daniel Watford 
390applications/workeffort/groovyScripts/workeffort/calendar/Upcoming.groovy

PASSED

Daniel Watford 
391applications/workeffort/groovyScripts/workeffort/calendar/Week.groovy

PASSED

Daniel Watford 
392applications/workeffort/groovyScripts/workeffort/content/WorkEffortContentWrapper.groovy

PASSED

Daniel Watford 
393applications/workeffort/groovyScripts/workeffort/find/WorkEffortSearchOptions.groovy

PASSED

Daniel Watford 
394applications/workeffort/groovyScripts/workeffort/find/WorkEffortSearchResults.groovy

PASSED

Daniel Watford 
395applications/workeffort/groovyScripts/workeffort/request/RequestList.groovy

PASSED

Daniel Watford 
396applications/workeffort/groovyScripts/workeffort/workeffort/WorkEffortServices.groovy

PASSED

Daniel Watford 
397build.gradle

PASSED

Daniel Watford 
398config/codenarc/codenarc.groovy

PASSED

Daniel Watford 
399framework/base/groovyScripts/test/SimpleTests.groovy

PASSED

Daniel Watford 
400framework/base/src/main/resources/org/apache/ofbiz/base/OfbizDslDescriptorForIntelliJ.gdsl

PASSED

Daniel Watford 
401framework/base/src/test/groovy/org/apache/ofbiz/base/util/FileUtilTests.groovy

PASSED

Daniel Watford 
402framework/common/groovyScripts/CcTypes.groovy

PASSED

Daniel Watford 
403framework/common/groovyScripts/CertKeystore.groovy

PASSED

Daniel Watford 
404framework/common/groovyScripts/ChildrenCustomScreenTypes.groovy

PASSED

Daniel Watford 
405framework/common/groovyScripts/CommonServices.groovy

PASSED

Daniel Watford 
406framework/common/groovyScripts/FindAutocompleteOptions.groovy

PASSED

Daniel Watford 
407framework/common/groovyScripts/GeoLocation.groovy

PASSED

408framework/common/groovyScripts/GetParentPortalPageId.groovy

PASSED

409framework/common/groovyScripts/GroovyServiceTest.groovy

PASSED

410framework/common/groovyScripts/InitTheme.groovy

PASSED

411framework/common/groovyScripts/ListPortalPortlets.groovy

PASSED

412framework/common/groovyScripts/PrepareDataForFlotGraph.groovy

PASSED

413framework/common/groovyScripts/SetTimeZoneFromBrowser.groovy

PASSED

414framework/common/groovyScripts/email/EmailServices.groovy

PASSED

415framework/common/groovyScripts/permission/CommonPermissionServices.groovy

PASSED

416framework/common/servicedef/services.xml

PASSED

417framework/entityext/groovyScripts/EntitySyncServices.groovy

PASSED

418framework/service/groovyScripts/test/TestServices.groovy

PASSED

419framework/service/src/main/groovy/org/apache/ofbiz/service/engine/GroovyBaseScript.groovy

PASSED

420framework/service/src/main/groovy/org/apache/ofbiz/service/test/ServicePurgeTest.groovy

PASSED

421framework/webtools/groovyScripts/artifactinfo/ArtifactInfo.groovy

PASSED

422framework/webtools/groovyScripts/artifactinfo/ComponentList.groovy

PASSED

423framework/webtools/groovyScripts/artifactinfo/TestSuiteInfo.groovy

PASSED

424framework/webtools/groovyScripts/artifactinfo/TestSuiteResults.groovy

PASSED

425framework/webtools/groovyScripts/cache/EditUtilCache.groovy

PASSED

426framework/webtools/groovyScripts/cache/FindUtilCache.groovy

PASSED

427framework/webtools/groovyScripts/cache/FindUtilCacheElements.groovy

PASSED

428framework/webtools/groovyScripts/datafile/ViewDataFile.groovy

PASSED

429framework/webtools/groovyScripts/entity/CheckDb.groovy

PASSED

430framework/webtools/groovyScripts/entity/EntityMaint.groovy

PASSED

431framework/webtools/groovyScripts/entity/EntityPerformanceTest.groovy

PASSED

432framework/webtools/groovyScripts/entity/EntityRef.groovy

PASSED

Gil Portenseigne 
433framework/webtools/groovyScripts/entity/EntityRefList.groovy

PASSED

Gil Portenseigne 
434framework/webtools/groovyScripts/entity/EntitySQLProcessor.groovy

PASSED

Gil Portenseigne 
435framework/webtools/groovyScripts/entity/FindGeneric.groovy

PASSED

Gil Portenseigne 
436framework/webtools/groovyScripts/entity/ModelInduceFromDb.groovy

PASSED

Gil Portenseigne 
437framework/webtools/groovyScripts/entity/ProgramExport.groovy

PASSED

Gil Portenseigne 
438framework/webtools/groovyScripts/entity/ViewGeneric.groovy

PASSED

Daniel Watford 
439framework/webtools/groovyScripts/entity/ViewRelations.groovy

PASSED

Daniel Watford 
440framework/webtools/groovyScripts/entity/XmlDsDump.groovy

PASSED

Daniel Watford 
441framework/webtools/groovyScripts/geo/GetGeoLocation.groovy

PASSED

442framework/webtools/groovyScripts/labelmanager/LabelManager.groovy

PASSED

Daniel Watford 
443framework/webtools/groovyScripts/labelmanager/UpdateManager.groovy

PASSED

Daniel Watford 
444framework/webtools/groovyScripts/labelmanager/ViewFile.groovy

PASSED

Daniel Watford 
445framework/webtools/groovyScripts/labelmanager/ViewReferences.groovy

PASSED

Daniel Watford 
446framework/webtools/groovyScripts/log/LogConfiguration.groovy

PASSED

Daniel Watford 
447framework/webtools/groovyScripts/service/AvailableServices.groovy

PASSED

Daniel Watford 
448framework/webtools/groovyScripts/service/JobDetails.groovy

PASSED

Daniel Watford 
449framework/webtools/groovyScripts/service/ScheduleJob.groovy

PASSED

Daniel Watford 
450framework/webtools/groovyScripts/service/ServiceResult.groovy

PASSED

Daniel Watford 
451framework/webtools/groovyScripts/service/Services.groovy

PASSED

452framework/webtools/groovyScripts/service/Threads.groovy

PASSED

453framework/webtools/groovyScripts/stats/StatBinsHistory.groovy

PASSED

454framework/webtools/groovyScripts/stats/StatsSinceStart.groovy

PASSED

455framework/webtools/src/main/groovy/org/apache/ofbiz/webtools/log/FetchLogs.groovy

PASSED

Daniel Watford 
456settings.gradle

PASSED

Daniel Watford 

Copy and paste the following lozenges for the Review column:

PASSED

UNSURE

WORK_NEEDED

WIP

  • No labels