Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

For non-trivial changes, it is best to get another committer to review your own patches before commit. Set the 'Patch Available' checkbox like other contributors, and then wait for a "+1" from another committer before committing.

Reject

Patches should be rejected which do not adhere to the guidelines in HowToContribute. Committers should always be polite to contributors and try to instruct and encourage them to contribute better patches. If a committer wishes to improve an unacceptable patch, then it should first be rejected, and a new patch should be attached by the committer for review.

Patches are rejected by editing the issue and un-setting the 'Patch Available' checkbox and adding a comment that politely details the reason(s) for rejection.

...